Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MO DeformableConv: fix a set of attributes #6806

Merged
merged 6 commits into from
Jul 29, 2021
Merged

MO DeformableConv: fix a set of attributes #6806

merged 6 commits into from
Jul 29, 2021
+4 −1

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Jul 26, 2021 •
edited
Loading

Details:

  • fix a set of attributes for opset < opset8

ticket: 56576, 56582

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests - N/A
  • Transformation tests N/A
  • Model Optimizer IR Reader check N/A

Documentation:

  • Supported frameworks operations list - N/A
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

@itikhono itikhono added the bug Something isn't working label Jul 26, 2021
@itikhono itikhono requested a review from lazarevevgeny July 26, 2021 16:28
@itikhono itikhono requested a review from a team July 26, 2021 16:28
@itikhono itikhono mentioned this pull request Jul 26, 2021
Merged
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Jul 26, 2021
@rkazants
Copy link
Contributor

rkazants commented Jul 27, 2021 •
edited
Loading

@itikhono, could you please add MO Code Review template and fill?

@pavel-esir
Copy link
Contributor

I had a network with DeformableConv and when DeformableConv-8 was turned on I had performance degradation since CPU was using evaluate for inference. Looks like because of some attribute v8 was not successfully downgraded in IE. And even cherry-picking the current PR does not solve the problem. Moreover error occurs on nG side during validation.

@itikhono could you please check your changes on the model in ticket 59003 ?

@itikhono
Copy link
Contributor Author

I had a network with DeformableConv and when DeformableConv-8 was turned on I had performance degradation since CPU was using evaluate for inference. Looks like because of some attribute v8 was not successfully downgraded in IE. And even cherry-picking the current PR does not solve the problem. Moreover error occurs on nG side during validation.

@itikhono could you please check your changes on the model in ticket 59003 ?

ok, I will check.

@itikhono itikhono requested a review from lazarevevgeny July 28, 2021 13:06
@lazarevevgeny lazarevevgeny enabled auto-merge (squash) July 28, 2021 14:08
@lazarevevgeny lazarevevgeny merged commit 6673a90 into openvinotoolkit:master Jul 29, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Jul 29, 2021
@itikhono @akuporos
MO DeformableConv: fix a set of attributes (openvinotoolkit#6806)
2ad7d1e 
* MO DeformableConv: fix a set of attributes

* codestyle

* resolve review comments

* resolve review comments
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@itikhono
MO DeformableConv: fix a set of attributes (openvinotoolkit#6806)
250a2be 
* MO DeformableConv: fix a set of attributes

* codestyle

* resolve review comments

* resolve review comments
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@itikhono @andrei-cv
MO DeformableConv: fix a set of attributes (openvinotoolkit#6806)
8bf4a91 
* MO DeformableConv: fix a set of attributes

* codestyle

* resolve review comments

* resolve review comments
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@itikhono @akuporos
MO DeformableConv: fix a set of attributes (openvinotoolkit#6806)
41ef653 
* MO DeformableConv: fix a set of attributes

* codestyle

* resolve review comments

* resolve review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

Assignees

@lazarevevgeny lazarevevgeny

@rkazants rkazants

Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itikhono @rkazants @pavel-esir @lazarevevgeny @openvino-pushbot